wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
308 stars 19 forks source link

Adds ability to launchInto an `AnyWorkflow` #103

Closed Tyler-Keith-Thompson closed 3 years ago

Tyler-Keith-Thompson commented 3 years ago

Linked Issue: #102

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #103 (0d1ba6d) into main (9cff36b) will increase coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   94.79%   94.82%   +0.03%     
==========================================
  Files          65       65              
  Lines        1670     1680      +10     
==========================================
+ Hits         1583     1593      +10     
  Misses         87       87              
Impacted Files Coverage Δ
...t_UIKit/Extensions/UIViewControllerAdditions.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7f7443c...0d1ba6d. Read the comment docs.

Tyler-Keith-Thompson commented 3 years ago

A quick note on this, the use-case, and potential ramifications.

The use case makes a ton of sense, hold onto an AnyWorkflow in a protocol or somewhere else and launch from it later, without having to worry about type information.

The ramification could be that more people think AnyWorkflow is just the right thing to use all the time. That's not horrible in itself, but it means new users of the library may unnecessarily start wrapping things in AnyWorkflow.