search

wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
308 stars 19 forks source link

Changes to support library development on an M1 mac #107

Closed Richard-Gist closed 3 years ago

Richard-Gist commented 3 years ago

Linked Issue:

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #107 (a3bc0bc) into main (082b711) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          65       65           
  Lines        1680     1680           
=======================================
  Hits         1593     1593           
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1925808...a3bc0bc. Read the comment docs.

Richard-Gist commented 3 years ago

According to this issue: https://github.com/mattgallagher/CwlPreconditionTesting/issues/21 we are unable to use CwlPreconditionTesting on ARM based devices (like the M1 macs).

Richard-Gist commented 3 years ago

There was one more change I had to do, but I believe it is on the person who has an M1 to do. SwiftLint from the command line failed because something was misconfigured. A quick google search later got me fixed up with the solution in this issue: https://github.com/realm/SwiftLint/issues/1466

brennanMKE commented 2 years ago

Thanks for this useful code. I copied it to a standalone project so that I could work out some details to make the build settings work as a package used by multiple test targets. I needed it to prepare this PR to support Apple Silicon.

brennanMKE commented 2 years ago

@Richard-Gist I packaged up these functions to make them easy to use as a dependency. It currently points to a forked branch which has the fix thanks for Saagar. I also have these functions limited to iOS and macOS since the underlying library only includes those 2 platforms. For other platforms it just skips them.