wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
307 stars 19 forks source link

Preview Providers now compile correctly #160

Closed Tyler-Keith-Thompson closed 2 years ago

Tyler-Keith-Thompson commented 2 years ago

Linked Issue: Closes #156

Checklist:


If Public API Has Changed:

codecov-commenter commented 2 years ago

Codecov Report

Merging #160 (4e67408) into main (3097cea) will decrease coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #160      +/-   ##
==========================================
- Coverage   91.27%   91.20%   -0.08%     
==========================================
  Files          92       92              
  Lines        2373     2353      -20     
==========================================
- Hits         2166     2146      -20     
  Misses        207      207              
Impacted Files Coverage Δ
...ent_SwiftUI/Extensions/ThenProceedExtensions.swift 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c97271...4e67408. Read the comment docs.

Tyler-Keith-Thompson commented 2 years ago

Some notes:

morganzellers commented 2 years ago
  • There is a breaking change in here. You used to be able to call self.thenProceed, which referred to a local method. Now that the method is global and the local methods are removed this no longer works and results in an error. @morganzellers what do you want to do about that?

I think we should version bump then. Does this force us to do a major version bump, or could we get away with bumping to v4.6.0?

morganzellers commented 2 years ago

I feel like I'm okay just gating this for our next version bump. It feels far away, but this isn't worth bumping to 5.0 now

Tyler-Keith-Thompson commented 2 years ago

Agreed. Should we create a 5.0 branch and merge it there?

morganzellers commented 2 years ago

Agreed. Should we create a 5.0 branch and merge it there?

I like that idea, I can do that