Closed Tyler-Keith-Thompson closed 2 years ago
Merging #160 (4e67408) into main (3097cea) will decrease coverage by
0.07%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 91.27% 91.20% -0.08%
==========================================
Files 92 92
Lines 2373 2353 -20
==========================================
- Hits 2166 2146 -20
Misses 207 207
Impacted Files | Coverage Δ | |
---|---|---|
...ent_SwiftUI/Extensions/ThenProceedExtensions.swift | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9c97271...4e67408. Read the comment docs.
Some notes:
rename
availability attribute however XCode 13.2.1 refused to be smart enough to pick the new global method. self.thenProceed
, which referred to a local method. Now that the method is global and the local methods are removed this no longer works and results in an error. @morganzellers what do you want to do about that?.
for their UIKit thenProceed
s. This can result in some really undesirable behavior especially if they just use fix
from xcode without paying attention (screenshots attached)
Step 1: Mistype, note that this auto-imports SwiftCurrent_SwiftUI which is "helpful"
Step 2: Notice an error and click
Step 3: Erroniously believe Xcode has your back and fix the comma
Step 4: Erroniously believe Xcode has your back and fix the args
Step 5: Have a workflow with 1 screen that launches with arguments of a WorkflowItem
and a secondary screen which will never show.
- There is a breaking change in here. You used to be able to call
self.thenProceed
, which referred to a local method. Now that the method is global and the local methods are removed this no longer works and results in an error. @morganzellers what do you want to do about that?
I think we should version bump then. Does this force us to do a major version bump, or could we get away with bumping to v4.6.0?
I feel like I'm okay just gating this for our next version bump. It feels far away, but this isn't worth bumping to 5.0 now
Agreed. Should we create a 5.0 branch and merge it there?
Agreed. Should we create a 5.0 branch and merge it there?
I like that idea, I can do that
Linked Issue: Closes #156
Checklist:
If Public API Has Changed: