wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
308 stars 19 forks source link

Fix typo in README #18

Closed pg closed 3 years ago

pg commented 3 years ago

Linked Issue:

Checklist:


If Applicable:


If Public API Has Changed:

cla-bot[bot] commented 3 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we do not seem to have the users @pg on file. In order for us to review and merge your code, please contact Workflow@wwt.com to get yourself added.

Richard-Gist commented 3 years ago

Thank you for the PR, and great catch on the typo. Your Pull Request is highlighting an issue in our pipeline for sonar_scan and since this is so small and documentation based, I'm going to override that failure.

Additionally, can you send Workflow@wwt.com an email granting WWT ownership of the change? Because you made this change after hours, we want to make sure we cross our 't's and dot our 'i's.

Richard-Gist commented 3 years ago

Thank you for the email @pg ! @cla-bot check

cla-bot[bot] commented 3 years ago

The cla-bot has been summoned, and re-checked this pull request!

Richard-Gist commented 3 years ago

I am merging without the sonar scan results because this is documentation only. For the sonar_scan failure I've created an Issue to track #20

Thanks, @pg for exercising our pipeline and the documentation fix!