wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
307 stars 19 forks source link

The docs were using thenPresent but they should be using thenProceed #185

Closed nickkaczmarek closed 2 years ago

nickkaczmarek commented 2 years ago

Linked Issue: #184

Checklist:

codecov-commenter commented 2 years ago

Codecov Report

Merging #185 (3a8c41e) into main (edaedd0) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #185   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          92       92           
  Lines        2375     2375           
=======================================
  Hits         2168     2168           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 510783c...3a8c41e. Read the comment docs.

nickkaczmarek commented 2 years ago

@morganzellers I was talking to @Tyler-Keith-Thompson about this before I merged and he mentioned that the api is actually thenProceed(with:) so I updated the examples.

morganzellers commented 2 years ago

@nickkaczmarek ah yes. My bad on that miss - I knew waiting to merge was a good choice.