wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
307 stars 19 forks source link

Adds a section to the Contributing guidelines covering how to install SwiftLint. #191

Closed morganzellers closed 2 years ago

morganzellers commented 2 years ago

Linked Issue: Closes #189

Checklist:

nickkaczmarek commented 2 years ago

I had started on this and totally didn't read your update this morning! 🤣 I confirmed on my personal machine that SwiftLint indeed needs to be installed before it'll work with our project so I'm glad this is in place. Didn't know about the pod install way though.

codecov-commenter commented 2 years ago

Codecov Report

Merging #191 (36cf48e) into main (edaedd0) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 36cf48e differs from pull request most recent head f8269bf. Consider uploading reports for the commit f8269bf to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   91.28%   91.28%           
=======================================
  Files          92       92           
  Lines        2375     2375           
=======================================
  Hits         2168     2168           
  Misses        207      207           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6b7b22...f8269bf. Read the comment docs.

nickkaczmarek commented 2 years ago

Also I think you want to update your PR template to be Closes #189 so that it closes the issue.