wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
307 stars 19 forks source link

Codecov report on README is lying #206

Open Tyler-Keith-Thompson opened 2 years ago

Tyler-Keith-Thompson commented 2 years ago

What happened?

Our codecov badge says 0% coverage but we have something like 90% coverage

Version

5.1.4 and 5.1.5

Relevant code sample

None

Relevant log output

None

Code of Conduct

Tyler-Keith-Thompson commented 1 year ago

Re-opening. As it still reports 0%...but when you click on it, it's higher???

Tyler-Keith-Thompson commented 1 year ago

More context: https://app.codecov.io/github/wwt/SwiftCurrent/commit/75d0baf4d6bcbf6e111fdfe5ca6d6babeb3b5260

Richard-Gist commented 1 year ago

The problem is that the upload is not including the code coverage report. Here's the uploaded coverage reports:

<<<<<< network
# path=coverage-report-SwiftCurrent.json
{"coverage":{}}<<<<<< EOF
# path=.github/fastlane/report.xml
<?xml version="1.0" encoding="UTF-8"?>
<testsuites>
  <testsuite name="fastlane.lanes">

      <testcase classname="fastlane.lanes" name="0: Verifying fastlane version" time="0.10954">

      </testcase>

      <testcase classname="fastlane.lanes" name="1: default_platform" time="0.001482">

      </testcase>

      <testcase classname="fastlane.lanes" name="2: clear_derived_data" time="0.041685">

      </testcase>

      <testcase classname="fastlane.lanes" name="3: scan" time="605.403753">

      </testcase>

  </testsuite>
</testsuites>
<<<<<< EOF

I'm not sure why I can't get it to pick up the .xcresult file that has the coverage. Looks like this all broke in the upgrade from 1.5 to 3.0.0. Perhaps we missed these steps when doing the update: https://github.com/codecov/codecov-action#migration-from-v1-to-v3