wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
307 stars 19 forks source link

Add variation of XCTAssertWorkflowLaunched for use with AnyWorkflow #207

Closed nallick closed 2 years ago

nallick commented 2 years ago

Linked Issue:

Checklist:


If Applicable:


If Public API Has Changed:

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

Tyler-Keith-Thompson commented 2 years ago

@nallick This looks good. I'll need you to sign the CLA before I can ~approve~ merge it.

nallick commented 2 years ago

@nallick This looks good. I'll need you to sign the CLA before I can ~approve~ merge it.

@Tyler-Keith-Thompson There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled. Also clicking the "recheck" button doesn't make a difference.

Screen Shot 2022-06-27 at 11 50 26 AM (2)
Tyler-Keith-Thompson commented 2 years ago

@nallick This looks good. I'll need you to sign the CLA before I can ~approve~ merge it.

@Tyler-Keith-Thompson There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled. Also clicking the "recheck" button doesn't make a difference.

Screen Shot 2022-06-27 at 11 50 26 AM (2)

I think the problem is you contributed with 2 accounts. One is "nallick" and the other is "nick-nallick-wwt". Both need to sign the agreement for it to work.

nallick commented 2 years ago

Yeah good catch, that was the problem. I have no idea how that second account got pulled in, but it's fixed now.