Fixes an issue where skipping views with a NavigationStack or Modal presentation style didn't work correctly with SwiftUI - Githubissues

wwt / SwiftCurrent

A library for managing complex workflows in Swift

https://wwt.github.io/SwiftCurrent/

Apache License 2.0

307 stars 19 forks source link

Fixes an issue where skipping views with a NavigationStack or Modal presentation style didn't work correctly with SwiftUI #210

Closed Tyler-Keith-Thompson closed 2 years ago

Tyler-Keith-Thompson commented 2 years ago

Linked Issue: #209

Checklist:

[x] Did you sign the Contributor License Agreement?
[x] Is the linter reporting 0 errors?
[x] Did you comply with our styleguide?
[ ] Is there adequate test coverage for your new code?
[x] Does the CI pipeline pass?

If Applicable:

[x] Did you test when the first item is skipped?
[x] Did you test when the last item is skipped?
[x] Did you test when middle items are skipped?
[x] Did you test when incorrect data is passed forward?
[x] Did you test proceeding backwards?

Tyler-Keith-Thompson commented 2 years ago

I'm gonna go ahead and merge, however the tests didn't catch this issue and I'm really not certain why. I'll poke around at them after prod is back up and running.