Closed Tyler-Keith-Thompson closed 3 years ago
Merging #73 (ada799f) into main (2baa360) will increase coverage by
1.19%
. The diff coverage is98.45%
.
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 97.25% 98.45% +1.19%
==========================================
Files 35 85 +50
Lines 985 3813 +2828
==========================================
+ Hits 958 3754 +2796
- Misses 27 59 +32
Impacted Files | Coverage Δ | |
---|---|---|
...mple/SwiftCurrent_UIKitTests/ModalStyleTests.swift | 99.04% <ø> (ø) |
|
...IKitTests/Storyboard/StoryboardLoadableTests.swift | 92.98% <ø> (ø) |
|
...nt_UIKitTests/TestUtilities/CustomAssertions.swift | 100.00% <ø> (ø) |
|
...t_UIKitTests/TestUtilities/TopViewController.swift | 80.00% <ø> (ø) |
|
...ent_UIKitTests/TestUtilities/UIKitAssertions.swift | 100.00% <ø> (ø) |
|
...ftCurrent_UIKitTests/TestUtilities/WaitUntil.swift | 100.00% <ø> (ø) |
|
...tCurrent_UIKitTests/UIKitConsumerLaunchTests.swift | 98.73% <ø> (ø) |
|
...ent_UIKitTests/UIKitConsumerPersistenceTests.swift | 99.39% <ø> (ø) |
|
...iftCurrent_UIKitTests/UIKitConsumerSkipTests.swift | 99.45% <ø> (ø) |
|
...IKitTests/UIKitConsumerWorkflowChainingTests.swift | 98.00% <ø> (ø) |
|
... and 105 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 66d9bd4...ada799f. Read the comment docs.
EOD: No real progress has been made on this. Debugging the failures that only happen in the pipeline is proving difficult.
EOD: I think this is it.
If it all looks good, then let's get it merged into trunk. If there are tweaks we want to make, then we may want to also add some linking in README to the other README's. Those are optimizations we could make in another PR though.
Linked Issue: #57
Checklist:
If Applicable:
If Public API Has Changed: