wwt / SwiftCurrent

A library for managing complex workflows in Swift
https://wwt.github.io/SwiftCurrent/
Apache License 2.0
308 stars 19 forks source link

Update PR Template to direct contributors to remove unneeded checklist items #83

Closed morganzellers closed 3 years ago

morganzellers commented 3 years ago

Checklist:

codecov-commenter commented 3 years ago

Codecov Report

Merging #83 (664f2e3) into main (ecd303a) will decrease coverage by 3.08%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   97.76%   94.68%   -3.09%     
==========================================
  Files          89       61      -28     
  Lines        5095     1598    -3497     
==========================================
- Hits         4981     1513    -3468     
+ Misses        114       85      -29     
Impacted Files Coverage Δ
...UIExampleTests/Views/ChangeUsernameViewTests.swift
...ts/Views/QRScannerFeatureOnboardingViewTests.swift
...nt_UIKitTests/TestUtilities/CustomAssertions.swift
...pleTests/ViewInspector/ViewHostingExtensions.swift
...e/SwiftCurrent_UIKitTests/UIKitConsumerTests.swift
...ample/SwiftUIExampleTests/Views/MFAViewTests.swift
...ampleTests/Views/AccountInformationViewTests.swift
...Current_UIKitTests/UIKitConsumerAbandonTests.swift
...pleTests/Views/MapFeatureOnboardingViewTests.swift
...wiftUIExampleTests/Views/MapFeatureViewTests.swift
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1afc14f...664f2e3. Read the comment docs.

Richard-Gist commented 3 years ago

I like how clean the final checklist looks. Do we have a plan for if the requester removes some items they didn't know they needed to do? I'm thinking like a version ramp because what they thought was a bug fix actually was an API change?

morganzellers commented 3 years ago

I like how clean the final checklist looks. Do we have a plan for if the requester removes some items they didn't know they needed to do? I'm thinking like a version ramp because what they thought was a bug fix actually was an API change?

That's something I was trying to consider as well. I don't really have any ideas other than us doing our due diligence to check the checklist against the changes.