search

wwtaourl / openid4java

Automatically exported from code.google.com/p/openid4java
0 stars 0 forks source link

replace commons logging with slf4j? #156

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
It is much better to use slf4j than commons logging. It is possible for 
everyone to stick to their chosen implementation. As most frameworks use slf4j 
it is quite a hassle to work around commons logging using a dummy 
implementation.

Also note this article: http://articles.qos.ch/thinkAgain.html and the 
references at the bottom.

Original issue reported on code.google.com by hielke.hoeve on 17 Jun 2011 at 7:52

GoogleCodeExporter commented 8 years ago 
Agreed. Having libraries use slf4j as their facade simplifies integration, and 
the existence of slf4j-jcl means projects that want to stick with 
commons-logging just need to include that to bridge across.

The APIs are similar enough that the change is simply a matter of changing the 
logger definitions and importing the dependencies; patch attached.

On top of this, it may be worth using slf4j's parameterised logging to remove 
the 'if (DEBUG)' checks.

Original comment by joe.walt...@gmail.com on 25 Feb 2015 at 2:36

Attachments: