Adding grid support - Githubissues

wwwdata / implicitly_animated_reorderable_list

Fork of the discontinued plugin to continue maintaining it

MIT License

32 stars 22 forks source link

Open abdelaziz-mahdy opened 2 years ago

abdelaziz-mahdy commented 2 years ago

i added grid support to the code

but i got a problem where the updated flicker

i think the code updates the widgets twice or the multiple list changes makes the ui not consistent

wwwdata commented 2 years ago

At first look I think we should change a couple of things:

Update .gitignore files so the additional unnecessary files from example and so on are ignored (I just rescued this repository from the original maintainer and they were also missing in the old project it seems)
I see a lot of copy and paste for the whole logic... This must be made reusable to avoid this.

I also allowed test runs now to check code formatting and so on.

abdelaziz-mahdy commented 2 years ago

I will try to make it reusable

My only problem was that the grid delgate needs to be passed to the last layer of your classes so it needed to be required in all of them

It can't be optional since this is required in grid view

But I will try to do it

kvenn commented 5 months ago

Any update on this?