wwweert123 / pe

0 stars 0 forks source link

Complicated sequence diagram #17

Open wwweert123 opened 12 months ago

wwweert123 commented 12 months ago

image.png This diagram might have been too complicated and defeats its purpose of allowing developers to understand the general idea of what the list sales by day function command is doing

nus-se-bot commented 11 months ago

Team's Response

Thank you for pointing this out! We included the essential steps in the sequence diagram. We agree that it may look complicated at first glance. However, if we were to trace through the sequence diagram, it is mostly made up of getters to aid in the user's understanding of the origins of the variables used in "List Sales" command, which we believe is essential. Non-essential steps are already filtered out such as the function "aggregatedOrders" used in the first loop.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that all the functions included and the interactions included are required for a good understanding of the "List Sales" command. However, there is a need to keep your diagram simple for future developers. A large diagram such as this might hinder the readability of the user. As stated in the textbook, you can use ref to break sequence diagrams into multiple diagrams.

image.png

image.png