search

wwylele / 3ds-save-tool

Tools to extract 3DS format save file. For richer functionality, use https://github.com/wwylele/save3ds
Apache License 2.0
48 stars 5 forks source link

sd_decrypt.py and Requirements file #6

Closed RickAfon closed 2 years ago

RickAfon commented 2 years ago

Added Counter (Cryptodome.Util) to the imported libs that was missing and added a "Requirements" text file.

wwylele commented 2 years ago

Thanks for the PR!

About the requirements text file:

RickAfon commented 2 years ago

I will try to fix that.

On Wed, Nov 2, 2022, 20:37 Weiyi Wang @.***> wrote:

Thanks for the PR!

About the requirements text file:

  • it shows up as binary file in github. Could you check if it has weird encoding or anything? like is it UTF-16 or UTF-8 with BOM? I recommend using BOM-less UTF8
  • the repo only needs one of pycryptodome or pycryptodomex. We can specify one, right?

— Reply to this email directly, view it on GitHub https://github.com/wwylele/3ds-save-tool/pull/6#issuecomment-1301493341, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJV3YRF2T5HRVOZWEHNJ5TLWGL3K3ANCNFSM6AAAAAARVSYUZ4 . You are receiving this because you authored the thread.Message ID: @.***>

RickAfon commented 2 years ago

Sorry for the delay, still learning how to use this platform. This PR was made because the "Counter" was missing and I couldn't use the program. I don't know if it had a better way to notify you, at least I tried.

wwylele commented 2 years ago

No problem, and thank you! The code looks good to me now. I am going to merge soon