wwylele / chocopy-rs

ChocoPy compiler written in Rust
MIT License
9 stars 0 forks source link

Great Project! #22

Open zzzyhtheonly opened 4 years ago

zzzyhtheonly commented 4 years ago

I'm also interested in transferring code generation into X86_64, so I find your works really fascinating!

It is really a well-formed design including OS compatibility, consideration of dividing static/dynamic links, implementation of optimization, GC and so on.

However I'm having a hard time figuring your code without comments since I'm new to Rust, so a trivial suggestion may not be useful: offering little more comments or docs if applicable :)

wwylele commented 4 years ago

More comments is definitely one thing I am working on! There is a document on overall design here where I am still adding more. Is there any component in particular you want me to add more comment first?

zzzyhtheonly commented 4 years ago

Thanks! I read your design document and took a glance at your code structure today, now I have a brief understanding about the usage of each file.

To me, I particularly focus on the backend implementations which I think they are in the chocopy-rs/chocopy-rs/src/gen/ ? I'm also interested in GC but it seems you are not completely done?

BTW in your profile I saw you like Reverse Engineering which I'm also interested in! Maybe we could build a connection and have further talks if you are willing to :)

wwylele commented 4 years ago

I updated some comments and design doc for garbage collection. The current GC is naive but functioning. The "Reverse Engineering" thing mainly reflects some game map editor I made, and my contribution to the 3DS emulator, citra. If you are interested, especially for citra, you can join in as well!