wwylele / mhrice

Monster Hunter Rise information website
http://mhrice.info
Apache License 2.0
106 stars 8 forks source link

Armor name weirdness #19

Open wwylele opened 2 years ago

wwylele commented 2 years ago

at https://github.com/wwylele/mhrice/blob/cc94a494613d83a9f60996285b6679f53e3802f9/src/extract/gen_pedia.rs#L1513 and https://github.com/wwylele/mhrice/blob/cc94a494613d83a9f60996285b6679f53e3802f9/src/extract/gen_pedia.rs#L1567-L1574 where we look up the armor name from msg, unlike other names, we uses armor ID to match against msg entry index, instead of the msg entry name. This appears to be the correct matching, but why is it? Is this the actually correct method, or there is a hidden armor ID -> msg entry name mapping somewhere? Could we also be wrong about using msg entry name anywhere else?

dtlnor commented 2 years ago

don't know if this discussion about msg file and GUIDs in discord server modding heaven useful for you