wwzeng1 / CoralME

A simple, fast and garbage-free matching engine order book that you can use as a starting point for your matching engines.
Apache License 2.0
0 stars 0 forks source link

Revert enum changes and fix compilation errors in OrderBookTest.java #17

Closed sweep-nightly[bot] closed 1 month ago

sweep-nightly[bot] commented 1 month ago

Purpose

This pull request aims to fix the compilation errors in the OrderBookTest.java file by reverting the changes that moved the enum classes out of the Order class and keeping them as inner classes. This will maintain the original structure of the codebase that the rest of the code expects.

Description

The changes in this pull request include:

  1. Reverting the changes in Order.java that moved the enum classes (TimeInForce, RejectReason, CancelRejectReason, CancelReason, ReduceRejectReason, Type, ExecuteSide, and Side) out of the Order class and keeping them as inner classes.
  2. Updating the imports in the OrderBookTest.java file to use the enum classes from the Order class instead of the standalone enum classes.
  3. Removing the standalone enum files (Side.java, TimeInForce.java, Type.java, ExecuteSide.java, CancelReason.java, and RejectReason.java) that were created earlier.

Summary

The key changes in this pull request are:

Fixes:

Failing CI in 4fe6fd6

In pull request https://github.com/wwzeng1/CoralME/pull/11. Continue the conversation here: http://localhost:3000/c/c41c4651-20cd-4042-a02b-fc6ac628446c.

To have Sweep make further changes, please add a comment to this PR starting with "Sweep:".

:book: For more information on how to use Sweep, please read our documentation.

Tracking ID: 0fe2881150