wwzeng1 / beekeeper-studio

Modern and easy to use SQL client for MySQL, Postgres, SQLite, SQL Server, and more. Linux, MacOS, and Windows.
https://www.beekeeperstudio.io
GNU General Public License v3.0
0 stars 0 forks source link

Sweep: In the ConnectionInterface.vue, make it clear when a connection problem is from the SSH tunnel #1

Open wwzeng1 opened 11 months ago

wwzeng1 commented 11 months ago

Currently it is not possible to differentiate between db connection errors and ssh connection errors.

Add a prefix to the error message to indicate where the error came from (database, ssh)

Checklist - [X] Modify `apps/studio/src/components/ConnectionInterface.vue` ✓ https://github.com/wwzeng1/beekeeper-studio/commit/f0833664cdca16113502cbd4fa2d754f56516eca ![Flowchart](http://24.199.78.105:8082/public/a7606b4fdd100d1be7938cdfce084dde560a90328d9e55e1d8dc80c1be8c35cd_1_flowchart.svg)
sweep-nightly[bot] commented 11 months ago

Here's the PR! https://github.com/wwzeng1/beekeeper-studio/pull/3.

💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. (tracking ID: 103072ea80)

Actions (click)

Sandbox Execution X

Here are the sandbox execution logs prior to making any changes:

Sandbox logs for eff2485
yarn install 1/1 ❌ (`1`)
yarn install v1.22.19
[1/4] Resolving packages...
warning Lockfile has incorrect entry for "watchpack@^1.7.4". Ignoring it.
[2/4] Fetching packages...
warning url-loader@1.1.2: Invalid bin field for "url-loader".
error @achrinza/node-ipc@9.2.2: The engine "node" is incompatible with this module. Expected version "8 || 10 || 12 || 14 || 16 || 17". Got "18.17.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Sandbox failed, so all sandbox checks will be disabled for this issue.

Install Sweep Configs: Pull Request

Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/wwzeng1/beekeeper-studio/blob/eff248585cbf93e016a47d8b2d4414734cb67622/apps/studio/src/components/ConnectionInterface.vue#L154-L405 https://github.com/wwzeng1/beekeeper-studio/blob/eff248585cbf93e016a47d8b2d4414734cb67622/apps/studio/docs/guide/README.md#L5-L85 https://github.com/wwzeng1/beekeeper-studio/blob/eff248585cbf93e016a47d8b2d4414734cb67622/apps/studio/src/components/connection/CommonAdvanced.vue#L1-L155 https://github.com/wwzeng1/beekeeper-studio/blob/eff248585cbf93e016a47d8b2d4414734cb67622/apps/studio/src/lib/db/server.ts#L13-L84 https://github.com/wwzeng1/beekeeper-studio/blob/eff248585cbf93e016a47d8b2d4414734cb67622/LICENSE.md#L590-L674

Step 2: ⌨️ Coding


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/ssh-db-error-handling.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord