wwzeng1 / landing-page

1 stars 5 forks source link

Sweep(slow): Fix the initials on the testimonials page, they all say JE #82

Open kevinlu1248 opened 1 year ago

kevinlu1248 commented 1 year ago

Details

No response

Checklist - [X] `src/components/User.tsx` ✅ Commit [`5a5d202`](https://github.com/wwzeng1/landing-page/commit/5a5d20229a08520a10fcbfc17bc2448a883ad14f)
• Add a new prop 'name' of type string to the User component. • Inside the User component, split the 'name' prop by space to get an array of names. • Take the first character of the first and last elements of the array to generate the initials. • Replace the hardcoded "JE" with the generated initials.
Sandbox Execution Logs
yarn install --ignore-engines && yarn add prettier 1/10 ✓
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
Done in 48.29s.
yarn add v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ prettier@3.0.3
info All dependencies
└─ prettier@3.0.3
Done in 7.28s.
yarn run prettier --write src/components/User.tsx 2/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 267ms
Done in 0.52s.
yarn run eslint src/components/User.tsx 3/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.17s.
yarn run tsc 4/10 ❌ (`2`)
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
src/components/Testimonials.tsx(26,18): error TS2741: Property 'name' is missing in type '{ children: Element; }' but required in type 'UserProps'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run prettier --write src/components/User.tsx 5/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 290ms
Done in 0.56s.
yarn run eslint src/components/User.tsx 6/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.04s.
yarn run tsc 7/10 ❌ (`2`)
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
src/components/Testimonials.tsx(26,18): error TS2559: Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & UserProps'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run prettier --write src/components/User.tsx 8/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 295ms
Done in 0.54s.
yarn run eslint src/components/User.tsx 9/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.06s.
yarn run tsc 10/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
Done in 6.45s.
- [X] `src/components/Testimonials.tsx` ✅ Commit [`47424ff`](https://github.com/wwzeng1/landing-page/commit/47424ffdbe60f6866047178c0b0673fd461c5abc)
• In the Testimonial component, pass the 'name' prop to the User component.
Sandbox Execution Logs
yarn install --ignore-engines && yarn add prettier 1/4 ✓
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
Done in 47.41s.
yarn add v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ prettier@3.0.3
info All dependencies
└─ prettier@3.0.3
Done in 7.07s.
yarn run prettier --write src/components/Testimonials.tsx 2/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/Testimonials.tsx
src/components/Testimonials.tsx 310ms
Done in 0.56s.
yarn run eslint src/components/Testimonials.tsx 3/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/Testimonials.tsx
Done in 2.08s.
yarn run tsc 4/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
Done in 6.36s.
sweep-ai[bot] commented 1 year ago

Here's the PR! https://github.com/wwzeng1/landing-page/pull/86.

💎 Sweep Pro: I used GPT-4 to create this ticket. You have unlimited GPT-4 tickets.


Actions (click)


Step 1: 🔎 Searching

I found the following snippets in your repository. I will now analyze these snippets and come up with a plan.

Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description. https://github.com/wwzeng1/landing-page/blob/20def24d42aa8786b6c735049a68101e266f0882/src/components/Testimonials.tsx#L3-L58

Step 2: ⌨️ Coding

yarn install --ignore-engines && yarn add prettier 1/10 ✓
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
Done in 48.29s.
yarn add v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ prettier@3.0.3
info All dependencies
└─ prettier@3.0.3
Done in 7.28s.
yarn run prettier --write src/components/User.tsx 2/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 267ms
Done in 0.52s.
yarn run eslint src/components/User.tsx 3/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.17s.
yarn run tsc 4/10 ❌ (`2`)
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
src/components/Testimonials.tsx(26,18): error TS2741: Property 'name' is missing in type '{ children: Element; }' but required in type 'UserProps'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run prettier --write src/components/User.tsx 5/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 290ms
Done in 0.56s.
yarn run eslint src/components/User.tsx 6/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.04s.
yarn run tsc 7/10 ❌ (`2`)
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
src/components/Testimonials.tsx(26,18): error TS2559: Type '{ children: Element; }' has no properties in common with type 'IntrinsicAttributes & UserProps'.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
yarn run prettier --write src/components/User.tsx 8/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/User.tsx
src/components/User.tsx 295ms
Done in 0.54s.
yarn run eslint src/components/User.tsx 9/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/User.tsx
Done in 2.06s.
yarn run tsc 10/10 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
Done in 6.45s.

yarn install --ignore-engines && yarn add prettier 1/4 ✓
yarn install v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
Done in 47.41s.
yarn add v1.22.19
warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > @chakra-ui/icons@2.0.18" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning "@chakra-ui/icons > @chakra-ui/icon@3.0.16" has unmet peer dependency "@chakra-ui/system@>=2.0.0".
warning " > @testing-library/user-event@14.4.3" has unmet peer dependency "@testing-library/dom@>=7.21.4".
warning " > avataaars@2.0.0" has incorrect peer dependency "react@^17.0.0".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "react-scripts > eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "react-window-ui > styled-components@5.3.9" has unmet peer dependency "react-is@>= 16.8.0".
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ prettier@3.0.3
info All dependencies
└─ prettier@3.0.3
Done in 7.07s.
yarn run prettier --write src/components/Testimonials.tsx 2/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/prettier --write src/components/Testimonials.tsx
src/components/Testimonials.tsx 310ms
Done in 0.56s.
yarn run eslint src/components/Testimonials.tsx 3/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/eslint src/components/Testimonials.tsx
Done in 2.08s.
yarn run tsc 4/4 ✓
yarn run v1.22.19
$ /repo/node_modules/.bin/tsc
Done in 6.36s.


Step 3: 🔁 Code Review

I have finished reviewing the code for completeness. I did not find errors for sweep/fix-testimonials-initials_13.

.


🎉 Latest improvements to Sweep:


💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. Join Our Discord