search

wxIshiko / wxCharts

A library to create charts in wxWidgets applications
https://www.wxishiko.com/wxCharts/
MIT License
114 stars 50 forks source link

support cmake and dll #199

Closed playgithub closed 2 years ago

playgithub commented 2 years ago

I'll test it tomorrow.

playgithub commented 2 years ago

Tested, built and installed successfully for debug and release.

xleclercq commented 2 years ago

Thank you for all the updates. I have made a few more comments but I think I'm done now and I should be able to accept soon.

playgithub commented 2 years ago

In demand of the reviewer of https://github.com/microsoft/vcpkg/pull/24263, port of wxCharts in vcpkg depends on this PR.

Could it be merged soon?

Thanks

xleclercq commented 2 years ago

Merged. Many thanks for the work.

As I suspected this breaks the existing bakefile build but I will take care of that by removing them and only relying on CMake going forward.

playgithub commented 2 years ago

Merged. Many thanks for the work.

My pleasure to contribute, I think this is the best C++ chart lib in MIT license, thanks.