wxMaxima-developers / wxmaxima

A gui for the computer algebra system Maxima built with wxWidgets
https://wxMaxima-developers.github.io/wxmaxima/
Other
460 stars 96 forks source link

Listen on localhost, accept only one connection. #126

Closed andrejv closed 13 years ago

andrejv commented 13 years ago

Converted from SourceForge issue 1873689, submitted by ars3niy

Currently wxMaxima listens on 0.0.0.0:4010 which allows anybody who can reach me over LAN or maybe even Internet to interrupt my work (by doing netcat my.machine 4010 and then Ctrl+C).

The first patch makes wxMaxima listen on 127.0.0.1:4010. The second patch makes it reject all subsequent connections which makes it almost impossible to interrupt work even from localhost.

andrejv commented 13 years ago

Submitted by ars3niy

Logged In: YES user_id=1952995 Originator: YES

File Added: wxmaxima-accept-one-connection.patch

andrejv commented 13 years ago

Submitted by andrejv

Logged In: YES user_id=1179910 Originator: NO

The first patch (wxmaxima-listen-on-localhost.patch) breaks wxMaxima on my MacBook. After applying it wxMaxima is unable to start the server. I didn't investigate why this happens. wxWidgets documentation suggests that AnyAddress should be used instead of LocalHost if possible, so I will reject the this patch for now.

The second patch (wxmaxima-accept-one-connection.path) looks OK so I will commit it.

Thanks for looking into this.

Andrej

andrejv commented 13 years ago

Submitted by ars3niy

Logged In: YES user_id=1952995 Originator: YES

After applying it wxMaxima is unable to start the server.

I've read something about problems with resolving "localhost" on Mac. If this is the case, addr.Hostname(wxT("127.0.0.1")) instead of addr.LocalHost() may work.

andrejv commented 13 years ago

Submitted by andrejv

Logged In: YES user_id=1179910 Originator: NO

Changing to addr.Howtname(wxT("127.0.0.1")) didn't work either.

Andrej

andrejv commented 13 years ago

Patches are not supported on github.