Trying to find a working tag for a new MacPorts release

MSoegtropIMC commented 1 year ago

@ryandesign and me are currently trying to create a new MacPorts version. I tried the latest 3 tags and all have very severe issues:

2023.05.1:

the help system does not seem to work except for displaying help in the sidebar
- if show help in browser is selected, it is also shown in side bar
- if show help in console is selected, nothing happens or it is also shown in sidebar (seems to depend on history)
the cursor navigation is broken. Most of the time when cursor left or cursor right is pressed, the cursor does move internally, but the displayed cursor does not move. This effect is a bit modal and sometimes it does work, but mostly it doesn't (e.g. after evaluating a cell with Shift+Enter)
setting the cursor with the mouse also has some odd effects, e.g. when I click at the end of the document to set the cursor there, it goes to after the first cell.
CMD+C copy of Maxima code does not work (menu edit copy does work, CMD+V does work)

2023.07, 2023.08

It is very hard to say something about these two versions because in these versions it takes 30..40 seconds to start up a maxima session. This happens for each new document and each open. As far as I can tell the cursor issues are gone, but cause of the delay I didn't test it much.

Summary

Can we have a patch of 2023.08 where whatever has changed from 2023.05.1 in maxima session management is undone or fixed?

Btw.: the long term issues with the preferences dialog seem to be fixed in 2023.05.1

Open Tasks

gunterkoenigsmann commented 12 months ago

As always the moment I make a release bad bugs are found => added commits 2240ae5af2194eb6764321f8098b1a96a469d723 and 5688eac7b8299e0164762bacbba5775364ca389c. The question now is when to make a new tag/release?

MSoegtropIMC commented 12 months ago

@gunterkoenigsmann : I didn't du much testing as yet. I regularly do Maxima stuff in the commuter train, but I was not in office last week. I expect to do quite a bit of testing until Thursday. Let's do the tag after testing.

gunterkoenigsmann commented 12 months ago

....and after I have fixed the bug that makes copying items as images unreliable.

MSoegtropIMC commented 12 months ago

FYI.: I am testing 9ad8fba4b2817038844146d3681d66ba20adb4e5 today.

MSoegtropIMC commented 12 months ago

@gunterkoenigsmann : I found one issue: if I select some text, say an identifier by double clicking on it, and then type to replace it, the curser wents somewhere else and types there. It might be that the curser ends up at the character count of the end of the selected regeion before it was deleted. Say if I select a 15 char identifier and type, I think the curser us 15 chars behind the position it should be.

MSoegtropIMC commented 12 months ago

@gunterkoenigsmann : starting nitpicking: what would be really nice is if the find & replace dialog (Ctrl+F) would focus the find text field by default. This might be editable in the dialog editor.

gunterkoenigsmann commented 12 months ago

I am currently trapped in real live (tm). But I've updated the original description of this issue with a checklist of things we definitively want to fix and I do plan not to change anything that isn't a bug fix or a translation update until we have a working release. In order to make sure that nothing gets lost I've additionally split the new findings into separate issues the checklist references.

gunterkoenigsmann commented 12 months ago

@gunterkoenigsmann : starting nitpicking: what would be really nice is if the find & replace dialog (Ctrl+F) would focus the find text field by default. This might be editable in the dialog editor.

That's exactly the kind of report that helped making wxMaxima streamlined enough that it can be fun working with it.

gunterkoenigsmann commented 11 months ago

Ok... ...the issues you have reported should now finally be resolved. The next task I plan to do is a big rewrite of the copy functionality that will take place in a branch.

gunterkoenigsmann commented 11 months ago

Added a few additional bug fixes to the main branch - and replaced many instances of operator[] by at(), as that adds range checking: Perhaps that makes subtle bugs visible.

MSoegtropIMC commented 11 months ago

OK, I will do a new build today and test it - I didn't have time to test the status from last Wednesday.

MSoegtropIMC commented 10 months ago

@gunterkoenigsmann : I didn't use wxMaxima the last 3 weeks much, so didn't do much testing (actually using it is the best test). I will use it more this week, so I tried the latest commit 9903c2b750ab112ed64dd666ad7f314219f31db7.

It looks pretty good! One minor thing: If I load a file, select a piece of text and type the text is now properly replaced. Only the Undo meno entry is not enabled. The undo entry is there, though. If I do another edit (insert text so that a new cell is created), undo works for the second and the first edit. So apparently it is just a question of enabling the menu entry.

This is a rather benign issue, since it rarely happens (only if an overwrite edit is the first thing one does, and one wants to undo it right away), so I would be fine with using this commit. Of course if you want to fix it, I would take that commit - as you prefer.

gunterkoenigsmann commented 10 months ago

Added all known issues that I want to fix before the new release to the checklist above

MSoegtropIMC commented 10 months ago

OK - please ping me when these issues are fixed. I keep using the commit from yesterday in my daily work.

gunterkoenigsmann commented 10 months ago

Ok... ...I believe the last 3 issues should be resolved by now.

MSoegtropIMC commented 10 months ago

Thanks, I make a quick test ...

MSoegtropIMC commented 10 months ago

I just tested 2af2a482b3570414a75b3f0d802c4b3eb5d24318.

Two items from the list don't work for me:

enabling of the undo button. I am doing the following: open existing file, select some text by drag with mouse, type one letter => Edit / undo is not enabled
the focussing of the search field in the file search dialog doesn't work any more - afair this did work in a previous test.

gunterkoenigsmann commented 10 months ago

Didn't manage to understand the undo function. But managed to write a new one. Hope it resolves all issues - and the focussing issue might be a timing issue => moved the activation command to after the focus event that possibly involves activating an item after I tried to activate it and did the same for all commands that activate the worksheet.

MSoegtropIMC commented 10 months ago

@gunterkoenigsmann : I tested wxMaxima a bit now and it is really good now.

There is one issue, though, with the regexp search. While entering a regexp I sometimes get a pop up dialog stating that the regexp is invalid (which is a very common intermediate situation when entering the regexp). Usually it just colors the edit field orange, but sometimes the pop up comes and on closing this popup Maxima crashes. I couldn't nail down when the pop up comes, though. It usually comes only after working for a while, but then regularly. In testing after a fresh start it is hard to reproduce. Maybe you can make sense out of it ... If not it shouldn't stop us from releasing.

gunterkoenigsmann commented 10 months ago

Ok... ...repaired the backwards and regexp search.

gunterkoenigsmann commented 10 months ago

...and wxMaxima now asks wxWidgets to provide a meaningful backtrace on crashes, if all the neccessary info and functionality is available.

MSoegtropIMC commented 10 months ago

Perfect timing - the last 2 weeks I had no opportunity to test it, but this week I plan to use wxMaxima a lot!

gunterkoenigsmann commented 9 months ago

Ok... ...@daute and me have once again resolved a big bunch off issues so I would be willing to create another release - but there is an issue that maybe needs checking beforehand: #1777 feels a bit like if once wxMaxima has changed the path of maxima to the current folder of the worksheet maxima no more knows where to find its share libraries. My guess is that that is no issue for macPorts.

gunterkoenigsmann commented 9 months ago

Ok... ...printing now works flawlessly and doing so caused many visual glitches in the worksheet t disappear. But arriving at this point was a big change => no idea if this has introduced new bugs...

MSoegtropIMC commented 9 months ago

Thanks, I will give it a try today - I didn't test much the begin of Dec version - too busy with other things, but it did basically look fine.

MSoegtropIMC commented 9 months ago

@gunterkoenigsmann : I have tested commit 4d312b48e05c6ac85fa23c74724034f1434f7caf from yesterday a bit. It looks OK, but one issue is that spacing in the editor, especially around assignment colons as in 'x : 3;' gets completely messed up when changing the zoom in any way.

MSoegtropIMC commented 8 months ago

@gunterkoenigsmann : I just tried commit fc52b7dec2c286cacdcd162592e14a07efd9fd61 from Dec 22 (from your previous post) and zooming doesn't completely mess up things there, but it doesn't zoom font size - the spacing gets larger but the letters stay the same size.

MSoegtropIMC commented 8 months ago

P.S.: commit 2af2a482b3570414a75b3f0d802c4b3eb5d24318 from Nov 15th - which I tested quite a bit - doesn't have the zoom issue, but the two (rather minor) issues I mentioned above. For me it would be OK to use this commit as a release for Mac - the issues are relatively minor compared to later commits.

gunterkoenigsmann commented 8 months ago

That commit had, according to the test suite, still random crashes when multiple windows were opened by the same process - and many of the checkmark menu items didn't work. But the info about the issue on zooming was important. With commit cb1468adaf4168031bf8a5d0317e22313a6bbbdf I have managed to resolve this one. Thanks for reporting it!

MSoegtropIMC commented 8 months ago

@gunterkoenigsmann : thanks! I can confirm that in cb1468adaf4168031bf8a5d0317e22313a6bbbdf the zoom issues (both bad spacing scaling and lack of font scaling) are fixed.

I will test this for some days.

MSoegtropIMC commented 8 months ago

@gunterkoenigsmann : I now tested cb1468adaf4168031bf8a5d0317e22313a6bbbdf for a while and I would say it is good for a release, so could you please tag it?

It sometimes happens that it is hard to place the cursor at the end of the document - one then has to click quite precisely below the last cell and clicking into the white space below it won't position the cursor at the end of the file as it ususually does. But I couldn't figure out when thuis happens. It is a state thing - when it does happen, it is reproducible until I reopen the file. But I wouldn't block a release cause of this minor issue.

Thank you for all the good work and fixes!

In the future I would appreciate if you would send me about every 3 months a request to test a tag, say via a test request issue here where you CC me (and maybe a few others).

MSoegtropIMC commented 7 months ago

@gunterkoenigsmann : is it possible to get a tag for the commit I tested?

gunterkoenigsmann commented 7 months ago

Everything is good if it helps updating wxMaxima on MacPorts.

gunterkoenigsmann commented 7 months ago

Release 24.01.0 is made of the commit you tested.

The only thing I have fixed in 24.02.1 that might be worth testing: Under Ubuntu 24.01.0 crashed if i opened a second wxMaxima window and then closed it again.

MSoegtropIMC commented 7 months ago

Thanks, I will look into it.

MSoegtropIMC commented 7 months ago

@gunterkoenigsmann : I thought I would have opportunity to test 24.02.1, but didn't so I am going to release 24.01.0 (I don't see issues starting multiple wxMaxima instances).

There is only one odd thing: in the wxMaxima about box it says "wxmaxima 23.12.0 Development scnapshot".

gunterkoenigsmann commented 7 months ago

If it works I guess it is a good version to make a release of.

About the "about dialogue": Thanks for the info. Will try to find out what is going on here.

MSoegtropIMC commented 7 months ago

If it works I guess it is a good version to make a release of.

The only thing I found is that sometimes I cannot place the cursor at the end of the document (below the last cell). A recompute usually fixes this. But I couldn't find out yet when this happens.

About the "about dialogue": Thanks for the info. Will try to find out what is going on here.

Should I wait for a fix or release it as is?

MSoegtropIMC commented 6 months ago

@gunterkoenigsmann : I am still waiting for an answer to:

About the "about dialogue": Thanks for the info. Will try to find out what is going on here.

Should I wait for a fix or release it as is?

gunterkoenigsmann commented 6 months ago

Release: Fixing this bug is enough code changes that it will likely create new ones.

MSoegtropIMC commented 6 months ago

OK, I will trigger the release.

Thanks a lot for all the support!

wxMaxima-developers / wxmaxima