search

wxWidgets / Phoenix

wxPython's Project Phoenix. A new implementation of wxPython, better, stronger, faster than he was before.
http://wxpython.org/
2.29k stars 516 forks source link

Which wxWidgets commit is used in a Phoenix release #1713

Open ChrisEt opened 4 years ago

ChrisEt commented 4 years ago

Could we include the commit hash of wxWidgets that was used for building a specific release somewhere?

Reason I am currently investigating a segfault in DragImage.BeginDrag() under GTK. I know I can find all sources in the PyPi package, but it would be a real help to be able to look at the commit history in Git. It took me some time to figure out that wxPython 4.0.7.post2 was built from wxWidgets Git branch WX_3_0_BRANCH from 2019-10-20 (commit 3b6a9f7)

I suggest that the build script reads the working copy's version (it could also check for local modifications) and writes this to a "release notes" section somewhere.

What do you guys think?

swt2c commented 4 years ago

Seems reasonable. Although you can always just browse to Phoenix/ext and then select the tag (e.g., wxPython-4.0.7.post2) you are interested in.

ChrisEt commented 4 years ago

Yes, you are right, the GitHub tag includes this information. I didn't see that.

image

Thanks a lot, you can close this issue (or keep it open if you like the idea with the build script) 👍

swt2c commented 4 years ago

I think it's a good idea to record that somewhere anyway...