search

wxWidgets / Phoenix

wxPython's Project Phoenix. A new implementation of wxPython, better, stronger, faster than he was before.
http://wxpython.org/
2.23k stars 510 forks source link

Make pip usage in wxget optional #2232

Closed StefanBruens closed 4 months ago

StefanBruens commented 1 year ago

As the code states, using pip to download is abusing it, and it is just a fallback in case neither wget nor urllib works.

jmoraleda commented 1 year ago

A comment about syntax: Is there an is missing in line 203? Should it say if not success and pip is not None:?

Metallicow commented 4 months ago

@jmoraleda correctly corrected. ... Looks fine to me ...