search

wxWidgets / wxWidgets

Cross-Platform C++ GUI Library
https://www.wxwidgets.org/
5.77k stars 1.7k forks source link

Add support for WebP image file format via libwebp. #24479

Open hoehermann opened 1 month ago

hoehermann commented 1 month ago

This is a pull request for #23489. Please refer to the conceptual discussion there. Discuss suggestions regarding this particular pull-request here.

Update: I consider this ready for merging.

Randalphwa commented 2 weeks ago

Because this requires a library that is not built by wxWidgets itself, I'm assuming that anyone wanting to use this functionality will not be able to use any of the pre-built binaries? Or are you envisioning that all the pre-built binaries should have webp support turned on by default? If the pre-built binaries aren't going to have webp support, then it should be documented that the user must build wxWidgets from source to get this functionality.

I'm not familiar with the Chromium repository system, but I do note that the issue you refered to ( https://chromium-review.googlesource.com/c/webm/libwebp/+/4868215 ) states that the change was merged on 9/19/2023 -- so wouldn't the fix be in the current 1.4 release (released 4/12/2024)?

hoehermann commented 1 week ago

I answered to Randalphwa's question at https://github.com/wxWidgets/wxWidgets/issues/23489#issuecomment-2080917306 to keep the discussion in one place.