search

wxWidgets / wxWidgets

Cross-Platform C++ GUI Library
https://www.wxwidgets.org/
5.77k stars 1.7k forks source link

#24491 - Update package.bat to include licence.txt in binary archives #24498

Closed ncook-hxgn closed 3 weeks ago

ncook-hxgn commented 3 weeks ago

Includes licence.txt in the binary archives for dev and release, win32 and x64, for MSVC. I wasn't able to find the packaging script for the headers archive..

ncook-hxgn commented 3 weeks ago

yay CI. Hopefully I can download some outputs from these and check my change worked (if the script doesn't fail)

doscott commented 3 weeks ago

I ran your changes to prepare an actual package. After prepending the ..\ to the archive path your changes have worked.

ncook-hxgn commented 3 weeks ago

@doscott thank you kindly good sir :)

Would you be able to direct me towards somewhere that I could make a similar change for cmake --build . --target install ? 🙏 -- I could test that, I have this branch checked out locally and got an install out of it earlier

doscott commented 3 weeks ago

Sorry, I have no knowledge of cmake.

vadz commented 3 weeks ago

Looks good and thanks for testing this! Will merge soon, and also backport to 3.2 a bit later.

ncook-hxgn commented 3 weeks ago

Thanks all :)