Resource compilation on msw

wxWidgets / wxWidgets

Cross-Platform C++ GUI Library

https://www.wxwidgets.org/

5.77k stars 1.7k forks source link

Resource compilation on msw #24504

Closed MapleLeaf-X closed 2 weeks ago

MapleLeaf-X commented 3 weeks ago

Build System Used

I build wxWidgets and/or my application using:

[ ] CMake
[ ] configure
[ ] mingw32-make with makefile.gcc
[ ] MSBuild (Microsoft Visual Studio solution file)
[x] nmake with makefile.vc
[ ] Xcode

Description

rc.exe is missing /nologo flag. it might affect cmake as well but I haven't tested it.

Platform and version information

wxWidgets version you are building: 3.3.0 (latest)
wxWidgets port you are building: wxMSW
OS and its version: Windows 10
Compiler being used: MSVS 2022
Non-default compiler options, if any : None

PBfordev commented 2 weeks ago

rc.exe is missing /nologo flag. it might affect cmake as well but I haven't tested it.

Could you please explain what exactly is the issue here, i.e., what errors/warnings/undesired behavior are you seeing?

Unlike the compiler and linker (cl.exe and link.exe), the resource compiler (rc.exe) does not support /nologo argument.

EDIT Actually it seems that at least some older versions of rc.exe (e.g., the one bundled with MSVS 2017) do support /nologo. But that two-line banner must have been there since a long time without presenting any issues (except noise).

MapleLeaf-X commented 2 weeks ago

Yeah it isn't technically an issue but I do consider it somewhat of a bug.

vadz commented 2 weeks ago

It seems too difficult to use the option only for rc versions that support it, so I don't think we're ever going to do it, especially considering that it's not really a problem in the first place, sorry.