wrong bgcolour in wxTextCtrl again

wxtrac commented 22 years ago

Issue migrated from trac ticket # 5154

component: wxGTK | priority: normal

2001-09-19 13:35:40: anonymous created the issue

I submitted patch no. 418555 some time ago (http://sourceforge.net/tracker/index.php?func=detail&aid=418555&group_id=9863&atid=309863). This patch was applied to the sources by Julian at Wed May 16 (version 1.114 of src/gtk/textctrl.cpp). However, some changes in src/gtk/textctrl.cpp broke it again, so I submitted another patch which was closed by vadz with the comment: "I think this problem had been fixed since 1.124, please check." So I checked, but the problem still exists. So here is a very small patch to fix it again. The patch was done against the latest CVS version 1.132 of src/gtk/textctrl.cpp. Hopefully, this can be fixed this time :-) Regards,

Roland Scholz

wxtrac commented 22 years ago

2001-09-19 13:40:05: anonymous commented

Logged In: NO

Damn, attaching a file signed this error message: Fatal error: Call to a member function on a non-object in common/tracker/ArtifactFile.class on line 106

So, here is the patch: --- textctrl.cpp.orig Wed Sep 19 13:13:24 2001 +++ textctrl.cpp Wed Sep 19 13:13:53 2001 @@ -326,7 +326,6 @@ m_cursor = wxCursor( wxCURSOR_IBEAM );

// FIXME: is the bg colour correct here? wxTextAttr attrDef( colFg,-
wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOW),

m_backgroundColour,
                 parent->GetFont() );

wxtrac commented 22 years ago

2001-09-19 13:45:03: anonymous commented

Logged In: NO

Hm, the patch isn't correctly formatted in my last comment. To clearify what the patch should do:

delete line 328 "// FIXME: is the bg colour correct here?"
change line 330 from "wxSystemSettings::GetSystemColour(wxSYS_COLOUR_WINDOW)," to "m_backgroundColour,"

Hope that help,

Roland Scholz

wxtrac commented 22 years ago

2001-09-28 16:33:40: @vadz commented

Applied, but pleeeease try to find a way to attach files properly, it is extremely incovenient to apply your patches otherwise. Again, you must be logged in for this to work.

Thanks!

wxWidgets / wxWidgets