search

wxWidgets / wxWidgets

Cross-Platform C++ GUI Library
https://www.wxwidgets.org/
6.18k stars 1.77k forks source link

non-themed fallback support for other wxNotebook orientation #7688

Closed wxtrac closed 2 years ago

wxtrac commented 18 years ago

Issue migrated from trac ticket # 7688

component: wxMSW | priority: low

2006-01-22 19:37:42: arkanes created the issue

This patch will fall back to an unthemed wxNotebook when an unsupported notebook orientation (wxNB_BOTTOM|wxNB_LEFT|wxNB_RIGHT) is requested, by disabling the XP theme.

If uxtheme is not available (but comctl32 version is still 6), then it will use the old behavior of clearing the styles.

It's not an optimal solution, but I think it is better than simply failing to support other orientations at all.

wxtrac commented 18 years ago

2006-01-22 19:37:42: arkanes uploaded file notebook.cpp.patch (2.2 KiB)

patch

wxtrac commented 18 years ago

2006-01-24 19:11:25: @vadz commented

I think it's just going to replace questions "why doesn't my notebook have the tabs on the left/right/bottom" with "why isn't my notebook themed". I honestly don't know what is preferrable...

wxtrac commented 18 years ago

2006-01-27 17:05:22: arkanes commented

Well, my preference (obviously) is for the fallback. Making a best try at support is preferable to just no support imo - I'm sure there will still be plenty of questions, but I find the answer "XP doesn't support it so we do what we can" more satisfying than "XP doesn't support it so we turn it off".

wxtrac commented 18 years ago

2006-02-11 16:41:54: @JulianSmart commented

Hi, this does seem to be a better solution than giving up, so now applied to both branches, thanks.