wxiaoyun / pe

0 stars 0 forks source link

bug: unnecessary compulsory fields for add command #4

Open wxiaoyun opened 3 months ago

wxiaoyun commented 3 months ago

Description

Steps to reproduce

Expected

Actual

Potential Suggestions

Screenshots

image.png

soc-pe-bot commented 2 months ago

Team's Response

Without making contact name and phone number compulsory, our app will no longer be an internship application manager that doubles as an internship contact management app.

Should we do this, we would violate the brownfield constraints by morphing AB3 in a different direction (since it is no longer a contact manager). Thus, it is necessary for us to keep contact name and phone number compulsory.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree with the team's decision on every other issue I have reported but I am afraid I must insist my position regarding this issue.

CareerSync User Guide

image.png

Decision refutation

I would argue that changing previously compulsory fields to optional field would fall under "evolving/enhancing/morphing the given code base...incrementally", hence it does not violate the brownfield constraint. Furthermore, this change (compulsory -> optional) is already made in my group's TP, so it should be fine.

Also in the UG, CareerSync is stated to be "internship application manager" instead of "contact manager", so I do not exactly follow the "it will no longer be a contact manager" argument made.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** ### CareerSync User Guide ![image.png](https://raw.githubusercontent.com/ForAeons/pe/main/files/4c77503d-379a-4367-b524-291006898d3e.png) ### Severity refutation Given that the user guide stated "CareerSync is an internship application manager designed to _simplify_ the management of internship applications", I would hope CareerSync to at least not _complicate_ management of internship applications. Most soc students apply for internship via online job portals such as LinkedIn, JobWiz, NodeFlair, etc, etc. A smaller portion of applications go through Recruiters, HRs directly (e.g. Career Fairs). As a soc students with majority of the applications that does not involve a contact, being forced to put dummy values for contact number, email would make this application quite unhelpful in managing my internship applications (feeding the application with noise data just to make it work). Furthermore, due to the bad job market, students often have to apply to more than a hundred roles for a chance of getting interviewed. Having additional road blocks to the application process simply make the internship worse for students. Hence, I insist on **Medium** severity.