search

wxstall / GridsSimp

0 stars 0 forks source link

RH above 100% #20

Closed wxmanted closed 5 years ago

wxmanted commented 6 years ago

RH calculation crashed on Day 8. It tried to put an RH above 100 percent.

Probably need to clip values at 0 and 100. But I'm wondering why it got a calculation above 100 in the first place. lcarlaw_190303_812164275

wxstall commented 6 years ago

I haven't been able to replicate this yet. It's possible that a forecaster can do stuff in step 1, exit GridsSimp prior to the "finalize" stage, and then relaunch GridsSimp starting at step 2. This would mean T/Td checks (along with the other check/derive functions) would never get called. That's the only way I can envision this happening.

I may need to move the integrity checks to "pre step 2" instead of "post step 1", but need to make sure this won't break anything else first.

wxstall commented 6 years ago

I put in a check for "if RH >100, then RH =100", although it's still concerning that this occurred. Routine NDFD integrity checks should still alert the forecaster if Td exceeds T at any given hour.

wxstall commented 5 years ago

Cautiously will mark this fixed for 0.1.4