The error "Saved groups are not editable" is thrown frequently.

aiktb commented 3 months ago

Describe the bug

Chromium currently does not support reloading tabs for "saved groups".

The error is due to tabs.reload in the following line of code.

https://github.com/wxt-dev/wxt/blob/faffe20a620ca70aad8cde41cd977ddc396a94c6/packages/wxt/src/virtual/utils/reload-content-scripts.ts#L84

A method to determine if a tab is in a saved group does not exist, so can it be caught?

Reproduction

No need zip.

Steps to reproduce

Add the page that injects the content script to the "saved group" and then trigger the content script update.

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (18) x64 Intel(R) Core(TM) Ultra 5 125H
    Memory: 11.52 GB / 15.43 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 20.15.0 - ~/.nvm/versions/node/v20.15.0/bin/node
    pnpm: 9.4.0 - ~/.nvm/versions/node/v20.15.0/bin/pnpm
  npmPackages:
    wxt: ^0.18.6 => 0.18.10

Used Package Manager

pnpm

Validations

[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

aklinker1 commented 3 months ago

Whelp that sucks. OK, I'll try catch it. I don't want to silence it, so I'll change it to a warning log. Otherwise people will ask me why the tab isn't reloading automatically.

aklinker1 commented 3 months ago

Released in v0.18.11

wxt-dev / wxt