Open wxwxwxwx9 opened 4 years ago
It perfectly describes the relationship we wanted to show. At first, we wanted to split it into 2 different diagrams but we did not do that because it may seem like they are two different instances.
Therefore, we combined it into one diagram to show the relationship between these classes more clearly even though there are a lot of them involved. Also, I changed the severity from medium to low as it is an aesthetic problem. Thanks.
Team chose [response.Rejected
]
Reason for disagreement: Hi there, I think the diagram can be redesigned to be portrait-based instead of the current landscape-based (or at least a hybrid of both) so that the words will be bigger.
I notice that words in diagrams tend to be squeezed to be very small whenever the diagram stretches widely in the horizontal direction.
As it is now, it is indeed quite difficult to read from a normal distance from the screen without squinting (or being excessively close to the screen to read it).
If we compare the text size in the DG to the text size in the Model diagram, we can see a drastic difference in the size and readability.
I agree that the severity should be low according to Prof. Akshay's response in the issues forum as shown below.
PE: how to respond to bug reports that are nitpicking in nature? #130
Suggestions -> Can reject Minor typos & Diagram too small -> low severity, accept ('cos affects readability) Diagrams too large -> can reject, unless diagram not fully visible in PDF, if latter case, low severity accept Too complicated -> accept; severity depends on how you want to defend your choice can be low or medium
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: [replace this with your explanation]