search

wxyz-abcd / node-haxball

The most powerful and lightweight API that allows you to develop your original Haxball(www.haxball.com) host, client, and standalone applications both on node.js and browser environments and also includes every possible hack and functionality that you can imagine.
MIT License
34 stars 13 forks source link

Input Control is bugged causes desynchronization #27

Closed punisherhaxball closed 1 year ago

punisherhaxball commented 1 year ago

The plugin modifyPlayerInput.js have some bugs.

Joined Player ID: 1 Host Player ID: 0

Problem: If command !input 1 0 is used, both players are frozen. Solution: Must check internal logic

Problem: While problem 1 is happening, if you open chat and then leave the room the host player (ID 0 in this case) has chat indicator open forever. Solution: Must check internal logic

Problem: If you put a non-existing player ID to command it is causing desynchronization. Solution: Before executing the command check for the ID to see if it exists or not.

wxyz-abcd commented 1 year ago

The chat indicator problem must be linked to the custom signal that I created myself to communicate between custom clients. The freezing problem? No idea yet. But I will find out.

wxyz-abcd commented 1 year ago

I just checked it on my website, it is working correctly, no desync happens at all. All of your cases worked correctly. I don't understand how it did not work on your side. Maybe you did something wrong? I don't know.

wxyz-abcd commented 1 year ago

I'm closing this issue since I've tested it enough to know that this issue does not exist anymore. If you still have it, open another issue.