search

wy-ei / vue-filter

:v: A collection of Vue.js filter. [Depressed]
MIT License
353 stars 37 forks source link

add ability to preserve words from being cut #11

Closed quentinus95 closed 7 years ago

quentinus95 commented 7 years ago

I have added the ability to preserve words from being cut.

quentinus95 commented 7 years ago

It is too complicated to take in account the ellipses size, the original string size, the limit size and avoiding words to be cutted (and I think it is a bit confusing) so I changed the filter to truncate the sentence to length size and add the ellipses.

Do you agree with these changes?

quentinus95 commented 7 years ago

ping @wy-ei

wy-ei commented 7 years ago

@quentinus95 If cut the origin string to specific length, things are getting clear. but this change may be impact other people who use this filter. I will change this filter in next minor version. thanks for your idea.

quentinus95 commented 7 years ago

@wy-ei do you have an idea on when you will change the filter?

Thx

wy-ei commented 7 years ago

Tomorrow, I will do it at tomorrow, sorry I am a totally procrastinator. 😭 @quentinus95