search

wyantb / HashMask

A browser addon for password fields, adding a visual hash to aid in memorability.
5 stars 0 forks source link

Rewrite lightbox with bootstrap modals #10

Closed nickserv closed 12 years ago

nickserv commented 12 years ago

Edit: title used to be "Make clicking outside of the lightbox on the options page close it"

wyantb commented 12 years ago

Actually, probably have to rewrite it from scratch anyway, doesn't actually work in IE. Could just use plan Bootstrap modals, probably.

nickserv commented 12 years ago

Good idea. If you want, you can assign me and I'll look into it.

wyantb commented 12 years ago

If you want to mess around, by all means, go ahead.

nickserv commented 12 years ago

Should I just put a carousel in a modal? (see http://twitter.github.com/bootstrap/javascript.html)

wyantb commented 12 years ago

Yes, basically. Really? Fuck around until you've got something you like. Fun fact: most of what I've been doing is just that.

Once done, we'll all take a look.

nickserv commented 12 years ago

This is mostly finished besides a couple of issues and incomplete bits, check out the carousel-examples branch.

EDIT: Actually, I also made a branch for getting this to work with modals alone. However, the carousel version does use one modal.

wyantb commented 12 years ago

I think the carousel-examples branch is fine. Not sure why you used the class 'carousel-example' for something in our html, but w/e.

Close if you're fine with it too.

nickserv commented 12 years ago

Ah, good point, I could have consolidated those two tags. And that id's there so different links can make our carousel do things. Closing issue.