search

wyantb / HashMask

A browser addon for password fields, adding a visual hash to aid in memorability.
5 stars 0 forks source link

Pressing a modifier key (or any other non-character key) makes HashMask blink for the delay period #51

Open nickserv opened 12 years ago

nickserv commented 12 years ago

Basically, at this point, ANY keypress will make HashMask clear itself, wait the delay time, and generate a new HashMask. That means that pressing a non-character key (like shift or ctrl) will make HashMask blink. We should either filter keypresses out or use an onchange event on password fields instead.

wyantb commented 11 years ago

Fixed in the refactor branch: https://github.com/wyantb/HashMask/tree/refactor

If you ever feel bored, feel free to test it out. Haven't revisited the options page or gh-pages branch, so both of those are broken in different ways I believe. But regardless, I think the core stuff is a bit cleaner now.

As for this specific issue: now, I compare the value of the password field from before the keyup event to that of it afterwards. If it's different, I remake the hash, otherwise, it stays the same.

nickserv commented 11 years ago

Ah, that sounds cool. I've been a bit busy lately, but I'll give that branch a look when I have the time.