search

wyantb / HashMask

A browser addon for password fields, adding a visual hash to aid in memorability.
5 stars 0 forks source link

HashMask does not display at all #8

Closed nickserv closed 12 years ago

nickserv commented 12 years ago

Since commit 46acfde061254fc6d01231803bdd3411514e355f, HashMask is not displayed at all on the options page and on other sites.

wyantb commented 12 years ago

Pff, what kind of bum writes code like that?

Anyway, addressed, mind verifying?

nickserv commented 12 years ago

To be honest, I'm not sure exactly what's causing it. I think it's the inject script (which you changed on this commit), since it doesn't work on the options page either.

wyantb commented 12 years ago

Nope, this change.

https://github.com/wyantb/HashMask/commit/09c8a7fb55bdf14b65d54ba072eebc46406a9c71

bg.js knows nothing of hashmask, so it can't muck with the settings.

In any case...does it work for you again?

nickserv commented 12 years ago

Wooo, it works. Thanks!