search

wyatt8740 / Game_Music_Emu

(GitLab: https://gitlab.com/wyatt8740/Game_Music_Emu ) - Fork of https://github.com/kode54/Game_Music_Emu that restores a cross-platform CMake build system. Currently, aims to be ABI-compatible with GME 0.6.2.
1 stars 2 forks source link

Fix up CMakeLists.txt #4

Open SteelT1 opened 6 years ago

SteelT1 commented 6 years ago

Fixes up CMakeLists.txt so the rest of the files is in the proper sections, honestly not sure if this is right, but it works and builds.

wyatt8740 commented 6 years ago

Um, looking at the commit, I'm not sure what's different. A lot of the libs are still basically in a 'miscellaneous' section, and I think I already did the gens/MAME YM2612 thing.

Thanks for the request, though. My car got screwed up by a minivan the other week, and I'm going to get it back from a body shop today, but once that's taken care of I can look at this in more detail.

I'm also new to this whole 'having people make pull requests' thing - usually my projects don't get that much attention!-- So I'm sorry if I'm handling these badly. I'm thankful that someone's helping out. :)

SteelT1 commented 6 years ago

The gens/MAME YM2612 thing was changed so before it checks if USE_GENS is enabled, it checks if USE_GME_VGM or USE_GME_GYM is enabled. Also put the remaining stuff under if (USE_GME_VGM), not sure if that's correct and nothing will break from doing this, though.