wyattriley / dvoa

Delaware Valley Orienteering Association
0 stars 0 forks source link

Update PHP version - it's from 2014... #9

Closed wyattriley closed 1 year ago

wyattriley commented 1 year ago

Plan - do in two steps - to 7.4, and then 8.1.

Check for any issues by browsing all over the site in between - including WordPress.

Once stable on 8.1, test the mail tool again, and try to revive that.

wyattriley commented 1 year ago

Checked for all deprecated APIs - found key ones (mysql_connect) that wouldn't work supposedly - so I upgraded those to mysqli... tested and they worked

And then I pulled forward to 7.0, then 8.1, and all seems well on a dozen pages.

wyattriley commented 1 year ago

Tried phpinfo check a few days ago, and apparently it was still on 5.6 - Vadim noticed too.

Poking around a bit, I found a directive in .htaccess specificing the php version, that apparently overrode that.

I commented out that line, and tested at 8.1, and phpinfo confirmed the change.

However admin2 pages were broken, so I rolled back to 7.4 - and most pages worked, but info still didn't.

Next: fix the "Info" page, and then consider also rolling further forward and checking for more errors.

wyattriley commented 1 year ago

Still haven't fixed the (rarely used) info page - but did get reports that eBoard posting & some forms were working. Found another instance of eregi() to update in a spam preventing file for eBoard, and in process.php there were duplicate variable names in a function that apparently php 5.6 was just fine with (not even throwing a warning.)

I still need to fix the info page, and do another pull & scrube of the error_log files for 'Fatal' - and perhaps clear more of the common warnings too.

wyattriley commented 1 year ago

info page fixed.

Still todo - re-query the error_log files and grep them for Fatal

wyattriley commented 1 year ago

Did the grep Fatal. Found a bunch of issues - many were from the spam files - many of which were still littered around the site - see issue #26