search

wycats / javascript-decorators

2.4k stars 127 forks source link

The new SPEC proposal is highly redundant, very limiting and does not even allow for class decoration #70

Closed silkentrance closed 8 years ago

silkentrance commented 8 years ago

@wycats

Given the new "SPEC" https://github.com/wycats/javascript-decorators/blob/master/interop/reusability.md

type Decorator = (target: Object, descriptor: DecoratorDescriptor): DecoratorDescriptor;

I do not see any way one would be able to decorate classes, aka constructor functions, or otherwise augment prototypes or their respective constructor functions during the decoration process?

Is this by intent or simply an oversight?

While this seems to be somewhat similar to the proposal made in #62, the latter does have support for class decorators and is not limiting in any way.

Limitations I see with the new spec proposal are

In addition to that I think that the new spec proposal is a bit over the top, introducing many new interfaces while a single DecoratorDescriptor interface having both a type property and a target property would suffice.

Not having the ability to decorate as freely as possible, will break existing frameworks such as Angular2 or core-decorators.js. While the latter is not gaining the traction right now that it deserves, the former will as it is based on TypeScript, which also relies on the ability to decorate as freely as possible, including class decoration.

Please note that having the ability to decorate as freely as possibly does not mean that one should ignore #66, as we also need to be able to decorate generator functions.

silkentrance commented 8 years ago

And, BTW is there some platform except for Twitter, where we could please discuss this stuff? IRC anyone? I find the current process lacking in transparency...

dead-claudia commented 8 years ago

@silkentrance I doubt this is intentional, but starting after the sentence/paragraph "Is this by intent or simply an oversight?", it reads a little ranty. Just trying to politely note area for improvement. :smile:

silkentrance commented 8 years ago

@isiahmeadows Hm, I did not mean it to sound like that, it was meant as an "objective" analysis of the current state of affairs. Will rework this as soon as I get home from work. Thanks for pointing this out.

Fixed. The description should now be "rant" free.

silkentrance commented 8 years ago

The new spec proposal is way more streamlined and provides for class decoration as well. Thanks @wycats and the TC39 team. Closing.