search

wycats / rake-pipeline-web-filters

MIT License
116 stars 34 forks source link

NeuterFilter works with additional_dependencies #46

Open ahawkins opened 12 years ago

ahawkins commented 12 years ago

All tests pass at the moment. I'm currently looking for a way to refactor the relationship between the NeuterFilter, NeuterWrapper and NeuterBatch because the code feels very odd. It's especially odd since now there additional responsibilities to implement additional_dependencies.

wagenet commented 11 years ago

Does additional_dependencies not work as it stands?

ahawkins commented 11 years ago

@wagenet it did IIRC if you explicitly declared all the required files. This PR takes that step out and make require detection automatic.

ahawkins commented 11 years ago

@wagenet @wycats ping, this should really be merged.