search

wycats / rake-pipeline-web-filters

MIT License
116 stars 36 forks source link

Avoid triggering IE's "conditional compilation" feature with sourceURLs #65

Closed gavacho closed 11 years ago

gavacho commented 11 years ago

This fixes an issue where minispade'd files don't work in IE8/9. The who what when where why's of it all are described here: http://www.trdev.co.uk/2011/05/17/ie-gotchas-using-the-coffeescript-plugin-for-requirejs/

hjr3 commented 11 years ago

:+1:

gavacho commented 11 years ago

I've verified that this doesn't break sourceMap support (tested in chrome) and doesn't cause IE to break because of sourceMap

gavacho commented 11 years ago

Is anyone maintaining this project?

lukemelia commented 11 years ago

Recent Chrome dev channel builds have deprecated //@ sourceUrl= in favor of //# sourceUrl=. Any reason not to move this filter to that syntax?

gavacho commented 11 years ago

It'd be good to know if IE supports //# in addition to //@

lukemelia commented 11 years ago

Some additional info here: http://updates.html5rocks.com/2013/06/sourceMappingURL-and-sourceURL-syntax-changed

lukemelia commented 11 years ago

I think that IE does not support source maps of any kind yet.

gavacho commented 11 years ago

IE definitely supports //@. This issue was opened because minispade-produced sourcemaps were braking IE :)

jednano commented 11 years ago

Seeing as TypeScript supports them, I'd be surprised if IE doesn't, but it is Microsoft. You never know.

lukemelia commented 11 years ago

@gavacho right but IE uses //@ for conditional comments, not for source maps. @jedhunsaker the articles about TypeScript support all refer to Chrome :)

gavacho commented 11 years ago

@lukemelia I think you're right. I think it looks like there's support because it has some special support for eval'd code blocks.

jednano commented 11 years ago

"Hopefully either the Visual Studio or IE (or both) team also pick up Source Maps and add support for them too."

http://www.aaron-powell.com/posts/2012-10-03-typescript-source-maps.html

lukemelia commented 11 years ago

Moving this discussion to #68