wyfo / apischema

JSON (de)serialization, GraphQL and JSON schema generation using Python typing.
https://wyfo.github.io/apischema/
MIT License
227 stars 18 forks source link

Add support for Python 3.12 #590

Closed cdce8p closed 1 year ago

cdce8p commented 1 year ago
cdce8p commented 1 year ago

@wyfo Would be awesome if you could take a look at it. This currently blocks us from installing requirements which depend on apischema on Python 3.12.

I believe, after the PR is merge, the only thing left would be to increment the version and do a new release.

codecov-commenter commented 1 year ago

Codecov Report

Merging #590 (8a971d5) into master (f1b6d59) will not change coverage. Report is 1 commits behind head on master. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #590   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files          62       62           
  Lines        5677     5677           
  Branches     1240     1240           
=======================================
  Hits         4996     4996           
  Misses        470      470           
  Partials      211      211           
wyfo commented 1 year ago

Thank you a lot for the PR! I will do a release tonight.

cdce8p commented 1 year ago

Thank you a lot for the PR! I will do a release tonight.

Thanks @wyfo! Just saw the new release. Unfortunately it seems the version wasn't updated so building apischema from source still won't work with Python 3.12 😕 Would you mind doing a new release with an updated version? https://github.com/wyfo/apischema/blob/v0.18.1/setup.py#L89

cdce8p commented 1 year ago

It works now! Thanks again 👍🏻