Update type mismatch to Exporter::HTTP for endpoint

wyhaines / opentelemetry-api.cr

The core of open telemetry instrumentation is the OpenTelemetry API/SDK. The initial aim of this shard is to implement the OpenTelemetry specification for metrics, traces, and logs.

Apache License 2.0

12 stars 1 forks source link

Update type mismatch to Exporter::HTTP for endpoint #18

Closed miry closed 2 years ago

miry commented 2 years ago

Expoter::HTTP uses private methods to initialize @endpoint_uri and also works difrently in case argument endpoint is String.

Add a sample tests to cover initialization part.

I see the code changed to support OTLP HTTP endpoint. Should it be extracted to separate Exporter and called "otlp-http"?

wyhaines commented 2 years ago

This commit contains all of the changes: https://github.com/wyhaines/opentelemetry-api.cr/commit/d81505fbd708c603e6f077a110523a53571d5b7c

wyhaines commented 2 years ago

Feel free to revise and reopen this if you think that I missed something, and it should be looked at more. Thank you!