Closed stakach closed 2 years ago
Is that in the release or in main? I think that I pushed a broken build to main right before I had to travel today, and I have not had a chance to go fix it yet.
Kirk Haines
On Tue, Apr 26, 2022, 19:27 Stephen von Takach @.***> wrote:
In the latest release
— Reply to this email directly, view it on GitHub https://github.com/wyhaines/opentelemetry-api.cr/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADFQDMJJKIKMZZNVEIYLLVHCJWNANCNFSM5UNRX6AQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
in the release, I see the error when adding this to my shard.yml
opentelemetry-instrumentation:
github: wyhaines/opentelemetry-instrumentation.cr
OK. That truly surprises me. I will resolve it asap
Thanks,
Kirk Haines
On Tue, Apr 26, 2022, 19:40 Stephen von Takach @.***> wrote:
in the release, I see the error when adding this to my shard.yml
[image: image] https://user-images.githubusercontent.com/368013/165421032-4300bdfd-0a43-4a32-aa1b-df842311cb74.png
— Reply to this email directly, view it on GitHub https://github.com/wyhaines/opentelemetry-api.cr/issues/2#issuecomment-1110439067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAADFQA2GXMQWIFBLXMJMM3VHCLHXANCNFSM5UNRX6AQ . You are receiving this because you commented.Message ID: @.***>
This would be the culprit https://github.com/wyhaines/opentelemetry-instrumentation.cr/blob/main/shard.yml#L16
I fixed the shard.yml file so that it doesn't point to main.
https://github.com/wyhaines/opentelemetry-api.cr/blob/main/src/opentelemetry-api/propagation/trace_context.cr#L3
In the latest release