search

wyllys66 / s3multi

S3 Multipart Upload Middleware for Openstack Swift proxy
Apache License 2.0
2 stars 6 forks source link

Merge into swift3 middleware #7

Open Grindizer opened 10 years ago

Grindizer commented 10 years ago

Hi,

I was wondering why aws s3 multipart is implemented as a separate middleware, is there any reason for that ? (I'm relatively new to the project so may be I missed some discussions ?)

What would be the problem of merging this work into swift3 middleware and thus gain more visibility ? (or at least may be have it as a stackforge project ?)

I will be happy to help for that by the way. Thanks in advance.

Nassim (IRC: nacim)

wyllys66 commented 10 years ago

It was not merged into swift3 because the S3 authentication always occurs AFTER swift3 processing. Some of the S3multi->Swift translations result in multiple swift calls, each of which requires a valid swift token. By putting s3multi later in the proxy pipeline, we can be assured that the initial request token was validated correctly and we do not have to create multiple tokens for each of the subsequent swift calls needed for a single s3multi request. Im not sure if it is even possible to do the s3multi steps in the swift3 module because of the authentication issues.

Grindizer commented 10 years ago

ok, I see now. Thanks for the answer though.

wyllys66 commented 10 years ago

I just had a talk with the swift3 maintainers and I think we (mostly them) are going to merge the modules. Check out http://github.com/fujita/swift3for details.

On Fri, Mar 28, 2014 at 11:30 AM, Grindizer notifications@github.comwrote:

ok, I see now. Thanks for the answer though.

Reply to this email directly or view it on GitHubhttps://github.com/wyllys66/s3multi/issues/7#issuecomment-38932062 .

Grindizer commented 10 years ago

is your link pointing out to swift3 github repository ? (cause even there I don't see anything regarding this topic :))

wyllys66 commented 10 years ago

Yeah, I thought it was in the issues list for that repo, but maybe not.

On Fri, Mar 28, 2014 at 11:46 AM, Grindizer notifications@github.comwrote:

is your link pointing out to swift3 github repository ? (cause even there I don't see anything regarding this topic :))

Reply to this email directly or view it on GitHubhttps://github.com/wyllys66/s3multi/issues/7#issuecomment-38933941 .