search

wymsee / cordova-imagePicker

Cordova Plugin For Multiple Image Selection
MIT License
407 stars 854 forks source link

Permissions update for Android 6.0+ #136

Closed poocart closed 2 years ago

poocart commented 8 years ago

Added READ_EXTERNAL_STORAGE permission dialog for Andorid 6.0+ users.

juliocbcotta commented 8 years ago

+1

Findiglay commented 8 years ago

+1

Nicolazinho commented 8 years ago

+1

vicentebalderas commented 8 years ago

+1

yzargari commented 7 years ago

+1

kaplanmaxe commented 7 years ago

+1

kumquat601 commented 7 years ago

+1 it's nice solution.

SanHoser commented 7 years ago

When are you going to merge?

dustinwag commented 7 years ago

+1

kumquat601 commented 7 years ago

@SanHoser Look at this code and change your MultiImageChooserActivity.java https://github.com/wymsee/cordova-imagePicker/pull/136/commits/20dbe9d027da990a8b7e514aa4b5262181beadc3

SanHoser commented 7 years ago

@Seongsoo-Kim Yes, I've cherry picked the class in order to unblock myself. However, I'd prefer pulling the code from the main repo to keep up with updates and fixes.

aabde commented 7 years ago

+1

Rakonda commented 7 years ago

+1

Findiglay commented 7 years ago

Any idea when this might be going in? It's quite an essential update.

mklilley commented 7 years ago

Agreed. I have test users of my app who are reporting crashses on first use of the imagePicker. Seems like this pull request will provide a big fix no?

EralpB commented 7 years ago

This is so important.

mklilley commented 7 years ago

I just tried the suggestion by @kumquat0601 i.e. I just replaced my MultiImageChooserActivity.java with the one here 20dbe9d027da990a8b7e514aa4b5262181beadc3 . My friend who is using Nexus 5 reported that the imagePicker didn't crash at first this time, but there were no images to select. Then when he loaded the app a second time the whole thing immediately crashed. Only after he gave permission to take a photo did the imagePicker then work ok. Has anyone else tried this kind of approach and did it work for you? Thanks

kumquat601 commented 7 years ago

@mklilley Oh, I didn't test Nexus devices. I only tested iPhone 5, galaxy series. Other Nexus users need to refer to your comments.

gagaXD commented 7 years ago

Any idea when this is going to be merged ?

kbondarev commented 7 years ago

+1 Please merge this

rpayanm commented 7 years ago

Why so much delay in merge this important issue?

badpenguin commented 7 years ago

How can i install this with "cordova plugin add" ? The plugin is crashing for me too :-/

wparad commented 7 years ago

@badpenguin Run this: cordova plugin add https://github.com/Findiglay/cordova-imagePicker.git#20dbe9d0 --save

fenglu09 commented 7 years ago

+1

nomanbiniqbal commented 7 years ago

+1

royipressburger commented 7 years ago

Any news regarding this?

wmenegali commented 7 years ago

I've changed the files on my own and it worked out great! What's happening with the merge?

alexislg2 commented 7 years ago

Works great thanks. Waiting for the merge!

amostech commented 7 years ago

+1 This shall be included in the main stream ASAP!

sarantist commented 7 years ago

Is there a reason for not merging?

amostech commented 7 years ago

@DMcNamara @gianpaj @sdushay

This sounds like an important merge, we are all using the new permission. Do you guys have plans to merge this into the main stream?

royipressburger commented 7 years ago

https://github.com/Telerik-Verified-Plugins/ImagePicker

This is a working replacement is someone is looking

bmwertman commented 7 years ago

Is this going to be merged? I just had the same permission error from a user running Android N on a Google Pixel device.

luiseduardobrito commented 7 years ago

+1

Spriz commented 7 years ago

Hi there! I took the liberty of merging your changes to my fork at https://github.com/Spriz/cordova-imagePicker :-)

sdushay commented 2 years ago

Hey @poocart can we close this?

poocart commented 2 years ago

Closed.