search

wymsee / cordova-imagePicker

Cordova Plugin For Multiple Image Selection
MIT License
407 stars 853 forks source link

PhoneGap Build fails with CLI 8.0.0 (Android Platform 7.0.0) #263

Closed mkihellas closed 6 years ago

mkihellas commented 6 years ago

Hello there, We are trying to update our App from Cordova CLI 7.1.0 to 8.0.0 and it seems that cordova-imagePicker plugin causes the build to fail on Android.

Looks like the problem is that you are using the source-file tag for images instead of the resource-file tag on plugin.xml. example

We checked all our 3rd party plugins and they are handling images using the resource-file tag. For example: example2

When we remove the cordova-imagePicker plugin, the build succeeds. More info can be found in this discussion here: https://forums.adobe.com/thread/2445961

Is there any chance to update your plugin and use the resource-file tag for images on plugin.xml, so we will be able to build with CLI 8.0.0?

mkihellas commented 6 years ago

I made it work in my repo: https://github.com/mkihellas/cordova-imagePicker I changed all the source-file regarding xml and png files to resource-file and PhoneGap builds successfully for Android with CLI 8.0.0

HINT: I had also to do some changes in ImageFetcher.java. mkihellas/cordova-imagePicker@61c18fc Check https://github.com/wymsee/cordova-imagePicker/issues/262 for more info.

christianidas commented 5 years ago

This should not be closed, right? Shouldn't it remain open until it has been fixed and versioned in the plugin?

rafaelmb commented 5 years ago

It should. But this repo is 2 years without update. And the issue owner decided to close, no interaction from the developers.